qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring
Date: Thu, 05 Nov 2015 09:37:47 +0100

> +#include <sys/inotify.h>

What happens on non-linux systems?

I guess we need some #ifdefs to not break the build there, or enable mtp
only for CONFIG_LINUX=y instead of CONFIG_POSIX=y.

> +enum inotify_event_type {
> +    CREATE = 1,
> +    DELETE = 2,
> +    MODIFY = 3,
> +};

Patch #3 removes this, I'd suggest to extent "enum mtp_code" with the
event codes here so we don't need this temporary thing.

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]