[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 6/7] monitor: add missed aio_context_acquire into vm_
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 6/7] monitor: add missed aio_context_acquire into vm_completion call |
Date: |
Fri, 6 Nov 2015 17:52:28 +0000 |
From: "Denis V. Lunev" <address@hidden>
Signed-off-by: Denis V. Lunev <address@hidden>
CC: Stefan Hajnoczi <address@hidden>
CC: Kevin Wolf <address@hidden>
CC: Luiz Capitulino <address@hidden>
CC: Markus Armbruster <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
monitor.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index 6cd747f..3295840 100644
--- a/monitor.c
+++ b/monitor.c
@@ -3408,13 +3408,18 @@ static void vm_completion(ReadLineState *rs, const char
*str)
readline_set_completion_index(rs, len);
while ((bs = bdrv_next(bs))) {
SnapshotInfoList *snapshots, *snapshot;
+ AioContext *ctx = bdrv_get_aio_context(bs);
+ bool ok = false;
- if (!bdrv_can_snapshot(bs)) {
- continue;
+ aio_context_acquire(ctx);
+ if (bdrv_can_snapshot(bs)) {
+ ok = bdrv_query_snapshot_info_list(bs, &snapshots, NULL) == 0;
}
- if (bdrv_query_snapshot_info_list(bs, &snapshots, NULL)) {
+ aio_context_release(ctx);
+ if (!ok) {
continue;
}
+
snapshot = snapshots;
while (snapshot) {
char *completion = snapshot->value->name;
--
2.5.0
- [Qemu-devel] [PULL 0/7] Block patches, Stefan Hajnoczi, 2015/11/06
- [Qemu-devel] [PULL 1/7] dataplane: simplify indirect descriptor read, Stefan Hajnoczi, 2015/11/06
- [Qemu-devel] [PULL 2/7] dataplane: support non-contigious s/g, Stefan Hajnoczi, 2015/11/06
- [Qemu-devel] [PULL 3/7] aio: Introduce aio_external_disabled, Stefan Hajnoczi, 2015/11/06
- [Qemu-devel] [PULL 4/7] aio: Introduce aio_context_setup, Stefan Hajnoczi, 2015/11/06
- [Qemu-devel] [PULL 5/7] aio: Introduce aio-epoll.c, Stefan Hajnoczi, 2015/11/06
- [Qemu-devel] [PULL 7/7] blockdev: acquire AioContext in hmp_commit(), Stefan Hajnoczi, 2015/11/06
- [Qemu-devel] [PULL 6/7] monitor: add missed aio_context_acquire into vm_completion call,
Stefan Hajnoczi <=
- Re: [Qemu-devel] [PULL 0/7] Block patches, Peter Maydell, 2015/11/06