qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 06/33] acpi: add aml_method_serialized


From: Xiao Guangrong
Subject: Re: [Qemu-devel] [PATCH v6 06/33] acpi: add aml_method_serialized
Date: Mon, 9 Nov 2015 19:18:25 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0



On 11/09/2015 07:14 PM, Michael S. Tsirkin wrote:
On Fri, Oct 30, 2015 at 01:56:00PM +0800, Xiao Guangrong wrote:
It avoid explicit Mutex and will be used by NVDIMM ACPI

Signed-off-by: Xiao Guangrong <address@hidden>

I'd rather you squashed these utility patches in with where
the code is used. This is just making it harder to review
as I have to jump back and forth.

Okay to me.


---
  hw/acpi/aml-build.c         | 26 ++++++++++++++++++++++++--
  include/hw/acpi/aml-build.h |  1 +
  2 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
index 9f792ab..8bee8b2 100644
--- a/hw/acpi/aml-build.c
+++ b/hw/acpi/aml-build.c
@@ -696,14 +696,36 @@ Aml *aml_while(Aml *predicate)
  }

  /* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefMethod */
-Aml *aml_method(const char *name, int arg_count)
+static Aml *__aml_method(const char *name, int arg_count, bool serialized)

Please don't prefix names with __.
what should you call this?
For example, you can call it aml_method_serialized.

Igor disliked that aml_method_serialized() is spepated from aml_method(), so i
will unify them as a single function instead. :)


  {
      Aml *var = aml_bundle(0x14 /* MethodOp */, AML_PACKAGE);
+    int methodflags;
+
+    /*
+     * MethodFlags:
+     *   bit 0-2: ArgCount (0-7)
+     *   bit 3: SerializeFlag
+     *     0: NotSerialized
+     *     1: Serialized
+     *   bit 4-7: reserved (must be 0)
+     */
+    assert(!(arg_count & ~7));

Or shorter assert(arg_count < 8);

Good to me.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]