[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] qemu, pkeys: add pkeys support for qemu cpu
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] qemu, pkeys: add pkeys support for qemu cpuid handling |
Date: |
Mon, 9 Nov 2015 13:24:04 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 09/11/2015 12:55, Huaitong Han wrote:
> @@ -351,6 +362,7 @@ static const char *cpuid_6_feature_name[] = {
> CPUID_7_0_EBX_FSGSBASE, CPUID_7_0_EBX_HLE, CPUID_7_0_EBX_AVX2,
> CPUID_7_0_EBX_ERMS, CPUID_7_0_EBX_INVPCID, CPUID_7_0_EBX_RTM,
> CPUID_7_0_EBX_RDSEED */
> +#define TCG_7_0_ECX_FEATURES (CPUID_7_0_ECX_PKU | CPUID_7_0_ECX_OSPKE)
This should be zero. Apart from this detail, the QEMU parts look good.
Paolo
> #define TCG_APM_FEATURES 0
> #define TCG_6_EAX_FEATURES CPUID_6_EAX_ARAT
>
> @@ -408,6 +420,13 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS]
> = {
> .cpuid_reg = R_EBX,
> .tcg_features = TCG_7_0_EBX_FEATURES,
> },
> + [FEAT_7_0_ECX] = {
> + .feat_names = cpuid_7_0_ecx_feature_name,
> + .cpuid_eax = 7,
> + .cpuid_needs_ecx = true, .cpuid_ecx = 0,
> + .cpuid_reg = R_ECX,
> + .tcg_features = TCG_7_0_ECX_FEATURES,
> + },
- [Qemu-devel] [PATCH 0/3] qemu, pkeys: add memory protection-key support, Huaitong Han, 2015/11/09
- [Qemu-devel] [PATCH 2/3] qemu, pkeys: add pkeys support for qemu xsave state handling, Huaitong Han, 2015/11/09
- [Qemu-devel] [PATCH 1/3] qemu, pkeys: add pkeys support for qemu cpuid handling, Huaitong Han, 2015/11/09
- Re: [Qemu-devel] [PATCH 1/3] qemu, pkeys: add pkeys support for qemu cpuid handling,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 3/3] qemu, pkeys: add pkeys support for qemu migration, Huaitong Han, 2015/11/09