Re: [Qemu-devel] [PATCH for 2.5 v2 1/1] migration: qemu_savevm_state_cleanup becomes mandatory operation

[Juan Quintela]

"Denis V. Lunev" <address@hidden> wrote:
> since commit
>     commit 94f5a43704129ca4995aa3385303c5ae225bde42
>     Author: Liang Li <address@hidden>
>     Date:   Mon Nov 2 15:37:00 2015 +0800
>
>     migration: defer migration_end & blk_mig_cleanup
>
> when actual .cleanup callbacks calling was removed from complete operations.
>
> The patch fixes regression introduced by the commit above results in
> 100% reliable assert for virtio-scsi VM with iothreads enabled during
> 'virsh create-snapshot' operation:
>     assert(i != mr->ioeventfd_nb);
>     memory_region_del_eventfd
>     virtio_pci_set_host_notifier_internal
>     virtio_pci_set_host_notifier
>     virtio_scsi_dataplane_start
>     virtio_scsi_handle_cmd
>     virtio_queue_notify_vq
>     virtio_queue_host_notifier_read
>     aio_dispatch
>
> Signed-off-by: Denis V. Lunev <address@hidden>
> Reviewed-by: Liang Li <address@hidden>
> CC: Paolo Bonzini <address@hidden>
> CC: Juan Quintela <address@hidden>
> CC: Amit Shah <address@hidden>

Reviewed-by: Juan Quintela <address@hidden>

And applied, thanks.