[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/10] snapshot: create bdrv_all_create_snapshot
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 07/10] snapshot: create bdrv_all_create_snapshot helper |
Date: |
Mon, 9 Nov 2015 17:33:07 +0000 |
User-agent: |
Mutt/1.5.23 (2015-06-09) |
On Sat, Nov 07, 2015 at 06:54:57PM +0300, Denis V. Lunev wrote:
> +int bdrv_all_create_snapshot(QEMUSnapshotInfo *sn, BlockDriverState **bad)
> +{
> + int err = 0;
> + BlockDriverState *bs = NULL;
> +
> + while (err == 0 && (bs = bdrv_next(bs))) {
> + AioContext *ctx = bdrv_get_aio_context(bs);
> +
> + aio_context_acquire(ctx);
> + if (bdrv_can_snapshot(bs)) {
> + err = bdrv_snapshot_create(bs, sn);
> + /* Tricky part here. First image contains VM state. The behavior
> + * is matched one in bdrv_all_find_vmstate_bs */
> + sn->vm_state_size = 0;
Please avoid the tricky part by passing in vm_state_bs and
vm_state_size. Then this function can do:
/* Write VM state size only to the image that contains the state */
sn->vm_state_size = (bs == bs1 ? vm_state_size : 0);
without making assumptions about the algorithm for choosing the device
to store vmstate data on.
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH for 2.5 v6 0/10] dataplane snapshot fixes, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 01/10] snapshot: create helper to test that block drivers supports snapshots, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 03/10] snapshot: create bdrv_all_delete_snapshot helper, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 05/10] snapshot: create bdrv_all_find_snapshot helper, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 06/10] migration: drop find_vmstate_bs check in hmp_delvm, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 02/10] snapshot: return error code from bdrv_snapshot_delete_by_id_or_name, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 04/10] snapshot: create bdrv_all_goto_snapshot helper, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 07/10] snapshot: create bdrv_all_create_snapshot helper, Denis V. Lunev, 2015/11/07
- Re: [Qemu-devel] [PATCH 07/10] snapshot: create bdrv_all_create_snapshot helper,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 09/10] migration: implement bdrv_all_find_vmstate_bs helper, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 10/10] migration: normalize locking in migration/savevm.c, Denis V. Lunev, 2015/11/07
- [Qemu-devel] [PATCH 08/10] migration: reorder processing in hmp_savevm, Denis V. Lunev, 2015/11/07
- Re: [Qemu-devel] [PATCH for 2.5 v6 0/10] dataplane snapshot fixes, Stefan Hajnoczi, 2015/11/09