Re: [Qemu-devel] [PATCH 4/7] tests: Add QOM property unit tests

[Andreas Färber]

Am 25.09.2015 um 17:01 schrieb Daniel P. Berrange:
> On Fri, Sep 25, 2015 at 02:39:45PM +0200, Andreas Färber wrote:
>> Add a test for parsing and setting a uint64 property.
>>
>> Signed-off-by: Andreas Färber <address@hidden>
>> ---
>>  MAINTAINERS             |   1 +
>>  tests/Makefile          |   3 ++
>>  tests/check-qom-props.c | 120 
>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 124 insertions(+)
>>  create mode 100644 tests/check-qom-props.c
> 
> FWIW, back in commit a31bdae5a76ecc060c1eb8a66be1896072c1e8b2 I added
> a  check-qom-proplist.c unit test, and later extended it with test
> for enums.

That's where your copyright and authorship came from.

> Perhaps your addition is best placed in there, or we could
> rename that test to check-qom-props.c so we just have one file for all
> property unit testing

I can only guess that my dislike was "/qom/proplist" as my test has
nothing to do with lists. Otherwise it looks similar enough. I'll rename
it and merge the two.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)