[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] i440fx: print an error message if user trie
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] i440fx: print an error message if user tries to enable iommu |
Date: |
Thu, 12 Nov 2015 09:46:24 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Bandan Das <address@hidden> writes:
> There's no indication of any sort that i440fx doesn't support
> "iommu=on""
>
> Signed-off-by: Bandan Das <address@hidden>
> ---
> hw/pci-host/piix.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
> index 7b2fbf9..f12593a 100644
> --- a/hw/pci-host/piix.c
> +++ b/hw/pci-host/piix.c
> @@ -301,6 +301,10 @@ static void i440fx_pcihost_realize(DeviceState *dev,
> Error **errp)
> static void i440fx_realize(PCIDevice *dev, Error **errp)
> {
> dev->config[I440FX_SMRAM] = 0x02;
> +
> + if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) {
> + fprintf(stderr, "i440fx doesn't support emulated iommu\n");
> + }
> }
>
> PCIBus *i440fx_init(const char *host_type, const char *pci_type,
error_report(), please.
If this is just a warning, please prefix the message with "warning: ".
If it isn't, exit(1).