[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v6 0/4] qapi: child add/delete supp
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH v6 0/4] qapi: child add/delete support |
|
Date: |
Fri, 13 Nov 2015 18:14:16 +0800 |
On Fri, Nov 13, 2015 at 5:37 PM, Wen Congyang <address@hidden> wrote:
> On 11/13/2015 05:28 PM, Stefan Hajnoczi wrote:
>> On Fri, Oct 30, 2015 at 02:11:30PM +0800, Wen Congyang wrote:
>>> Ping...
>>
>> Tips for faster code review:
>>
>> It helps to mention the specific person you are expecting review from
>> when the CC list is long. For example, "Kevin: ping".
>
> Do you mean when I ping a patch, I need write 'xxx: ping' if the CC list
> is long?
>
>>
>> Keeping the CC list short can result in faster code review than a long
>> CC list because it's obvious who needs to reply.
>
> Thanks, I always put them in the TO list, and the CC list contains the
> people who is interested this patch.
That is good practice and usually enough. In this case it seems
reviewers didn't act for some time and I guess it was because they
were waiting for the other reviewers (deadlock).
If you identify the person who needs to take the next action by
including their name in the ping or keeping the CC list small, then
deadlock is unlikely.
It's just a suggestion that I think will help because I noticed this
patch (and other COLO patches) sometimes don't receive review comments
for a long time.
Stefan