qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/3] fix clang negative signed bit shift warning


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 0/3] fix clang negative signed bit shift warning
Date: Tue, 17 Nov 2015 11:50:10 +0800
User-agent: Mutt/1.5.23 (2015-06-09)

On Mon, Nov 16, 2015 at 03:20:12PM +0000, Peter Maydell wrote:
> On 16 November 2015 at 14:23, Peter Maydell <address@hidden> wrote:
> > My clang-3.7 build (it's part of fbinfer) also complains about:
> >
> > /Users/pm215/src/qemu/hw/audio/fmopl.c:1085:39: warning: shifting a
> > negative signed value is undefined [-Wshift-negative-value]
> >                 data = Limit( outd[0] , OPL_MAXOUT, OPL_MINOUT );
> >                                                     ^~~~~~~~~~
> > /Users/pm215/src/qemu/hw/audio/fmopl.c:75:28: note: expanded from
> > macro 'OPL_MINOUT'
> > #define OPL_MINOUT (-0x8000<<OPL_OUTSB)
> >                     ~~~~~~~^
> 
> I sent a patch for that one. The MIPS stuff I'll leave for somebody
> else at least for now...

Thanks.  I don't plan to investigate the audio one soon.

Stefan

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]