Re: [Qemu-devel] [PATCH COLO-Frame v10 10/38] COLO: Add a new RunState RUN_STATE_COLO

[zhanghailiang]

On 2015/11/14 0:47, Eric Blake wrote:
> On 11/03/2015 04:56 AM, zhanghailiang wrote:
> > Guest will enter this state when paused to save/restore VM state
> > under colo checkpoint.
> >
> > Cc: Eric Blake <address@hidden>
> > Cc: Markus Armbruster <address@hidden>
> > Signed-off-by: zhanghailiang <address@hidden>
> > Signed-off-by: Li Zhijian <address@hidden>
> > Signed-off-by: Gonglei <address@hidden>
> > Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> > Reviewed-by: Eric Blake <address@hidden>
> > ---
> >   qapi-schema.json | 7 ++++++-
> >   vl.c             | 8 ++++++++
> >   2 files changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --git a/qapi-schema.json b/qapi-schema.json
> > index 5c4fe6d..49f2a90 100644
> > --- a/qapi-schema.json
> > +++ b/qapi-schema.json
> > @@ -154,12 +154,15 @@
> >   # @watchdog: the watchdog action is configured to pause and has been triggered
> >   #
> >   # @guest-panicked: guest has been panicked as a result of guest OS panic
> > +#
> > +# @colo: guest is paused to save/restore VM state under colo checkpoint (since
> > +# 2.5)
>
> Will need a tweak to 2.6;

OK, i will update it in next version

> >   ##
> >   { 'enum': 'RunState',
> >     'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'paused',
> >               'postmigrate', 'prelaunch', 'finish-migrate', 'restore-vm',
> >               'running', 'save-vm', 'shutdown', 'suspended', 'watchdog',
> > -            'guest-panicked' ] }
> > +            'guest-panicked', 'colo' ] }
> >
> >   ##
> >   # @StatusInfo:
> > @@ -434,6 +437,8 @@
> >   #
> >   # @failed: some error occurred during migration process.
> >   #
> > +# @colo: VM is in the process of fault tolerance. (since 2.5)
>
> Likewise.  But my R-b still stands after that minor tweak.

Thanks.