Re: [Qemu-devel] [PATCH v2 5/7] stubs: cocoa_display_init() stub

[Peter Maydell]

On 12 November 2015 at 19:02, Eduardo Habkost <address@hidden> wrote:
> One less #ifdef in vl.c.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> Changes v1 -> v2:
> * Move stub file to stubs/ui/
> ---
>  stubs/ui/Makefile.objs |  1 +
>  stubs/ui/cocoa.c       | 10 ++++++++++
>  vl.c                   |  2 --
>  3 files changed, 11 insertions(+), 2 deletions(-)
>  create mode 100644 stubs/ui/cocoa.c
>
> diff --git a/stubs/ui/Makefile.objs b/stubs/ui/Makefile.objs
> index 2e4c924..ce9a0ce 100644
> --- a/stubs/ui/Makefile.objs
> +++ b/stubs/ui/Makefile.objs
> @@ -1,3 +1,4 @@
>  stub-obj-y += vnc.o
>  stub-obj-y += curses.o
>  stub-obj-y += sdl.o
> +stub-obj-y += cocoa.o
> diff --git a/stubs/ui/cocoa.c b/stubs/ui/cocoa.c
> new file mode 100644
> index 0000000..ef07a8a
> --- /dev/null
> +++ b/stubs/ui/cocoa.c
> @@ -0,0 +1,10 @@
> +#include "qemu-common.h"
> +#include "ui/console.h"
> +#include "qemu/error-report.h"
> +
> +void cocoa_display_init(DisplayState *ds, int full_screen)
> +{
> +    /* This must never be called if CONFIG_COCA is disabled */

"CONFIG_COCOA".

thanks
-- PMM