[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/18] armv7m: expand NVIC state
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 05/18] armv7m: expand NVIC state |
Date: |
Tue, 17 Nov 2015 18:10:14 +0000 |
On 9 November 2015 at 01:11, Michael Davidsaver <address@hidden> wrote:
> Expand the NVIC to fully support -M priorities and masking.
> Doesn't use GIC code.
>
> Move some state to ARMCPU to allow calculation of exception masking.
>
> Add storage for PRIGROUP to configure group/sub-group split.
> Track group and sub-group in separate fields for quick comparison.
> Mix in vector # with sub-group as per tie breaking rules.
>
> NVIC now derives directly from SysBusDevice, and
> struct NVICClass is eliminated.
>
> Also add DPRINTF() macro.
>
> Signed-off-by: Michael Davidsaver <address@hidden>
This patch doesn't compile, because you've removed the definition of
NVICClass, NVIC_CLASS, etc, but not their uses. A patchset needs to
compile after every patch in it, not just at the end when all patches
are applied. You'll need to rearrange your changes between patches
a bit.
thanks
-- PMM
- [Qemu-devel] [PATCH 00/18] Fix exception handling and msr/mrs access, Michael Davidsaver, 2015/11/08
- [Qemu-devel] [PATCH 05/18] armv7m: expand NVIC state, Michael Davidsaver, 2015/11/08
- Re: [Qemu-devel] [PATCH 05/18] armv7m: expand NVIC state,
Peter Maydell <=
- [Qemu-devel] [PATCH 06/18] armv7m: new NVIC utility functions, Michael Davidsaver, 2015/11/08
- [Qemu-devel] [PATCH 04/18] armv7m: Explicit error for bad vector table, Michael Davidsaver, 2015/11/08
- [Qemu-devel] [PATCH 03/18] armv7m: Complain about incorrect exception table entries., Michael Davidsaver, 2015/11/08
- [Qemu-devel] [PATCH 01/18] armv7m: MRS/MSR handle unprivileged access, Michael Davidsaver, 2015/11/08
- [Qemu-devel] [PATCH 02/18] armv7m: Undo armv7m.hack, Michael Davidsaver, 2015/11/08
- [Qemu-devel] [PATCH 08/18] armv7m: fix RETTOBASE, Michael Davidsaver, 2015/11/08