qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 5/5] vnc: distiguish between ipv4/ipv6 omitte


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 5/5] vnc: distiguish between ipv4/ipv6 omitted vs set to off
Date: Tue, 17 Nov 2015 17:12:17 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 11/17/2015 10:00 AM, Daniel P. Berrange wrote:
> The VNC code for interpreting QemuOpts does not currently
> distinguish between ipv4/ipv6 being omitted, and being
> set to 'off', because historically the 'ipv4' and 'ipv6'
> options were just flags which did not accept a value.
> 
> The upshot is that if someone runs
> 
>   $QEMU -vnc localhost:1,ipv6=off
> 
> QEMU still uses PF_UNSPEC and thus may still bind to IPv6,
> when it should use PF_INET.
> 
> This is another instance of the problem previously fixed
> for chardevs in
> 
>   commit b77e7c8e99f9ac726c4eaa2fc3461fd886017dc0
>   Author: Paolo Bonzini <address@hidden>
>   Date:   Mon Oct 12 15:35:16 2015 +0200
> 
>     qemu-sockets: fix conversion of ipv4/ipv6 JSON to QemuOpts
> 
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  ui/vnc.c | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]