Re: [Qemu-devel] [PATCH] vhost-user: fix log size

[Marc-André Lureau]

Reviewed-by: Marc-André Lureau <address@hidden>

On Wed, Nov 18, 2015 at 3:16 PM, Michael S. Tsirkin <address@hidden> wrote:
> commit 2b8819c6eee517c1582983773f8555bb3f9ed645
> ("vhost-user: modify SET_LOG_BASE to pass mmap size and offset")
> passes log size in units of 4 byte chunks instead of the
> expected size in bytes.
>
> Fix this up.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
>  hw/virtio/vhost-user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index 71c3e16..1b6c5ac 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -206,7 +206,7 @@ static int vhost_user_set_log_base(struct vhost_dev *dev, 
> uint64_t base,
>      VhostUserMsg msg = {
>          .request = VHOST_USER_SET_LOG_BASE,
>          .flags = VHOST_USER_VERSION,
> -        .payload.log.mmap_size = log->size,
> +        .payload.log.mmap_size = log->size * sizeof(*(log->log)),
>          .payload.log.mmap_offset = 0,
>          .size = sizeof(msg.payload.log),
>      };
> --
> MST
>



-- 
Marc-André Lureau