[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH 18/77] ppc: Rework POWER7 & POWER8 ex
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH 18/77] ppc: Rework POWER7 & POWER8 exception model |
Date: |
Thu, 19 Nov 2015 21:31:52 +1100 |
On Thu, 2015-11-19 at 17:44 +1100, David Gibson wrote:
>
> > - /* new interrupt handler msr */
> > - new_msr = env->msr & ((target_ulong)1 << MSR_ME);
> > + /* new interrupt handler msr preserves existing HV and ME unless
> > + * explicitly overriden
> > + */
> > + new_msr = env->msr & (((target_ulong)1 << MSR_ME) | MSR_HVB);
>
> Ouch. The fact that MSR_ME is a bit number, but MSR_HVB is a mask is
> certainly confusing, but that's a pre-existing problem.
That shit bit me more than once indeed, but it's a fix for another day.
.../...
> >
> > case POWERPC_EXCP_HDSI: /* Hypervisor data storage exception
> > */
> > srr0 = SPR_HSRR0;
> > srr1 = SPR_HSRR1;
> > new_msr |= (target_ulong)MSR_HVB;
> > new_msr |= env->msr & ((target_ulong)1 << MSR_RI);
> > + ail = 0;
>
> Do you need to set ail explicitly here, given the general ail logic below?
Not on this indeed. I think that's a remnant of how that patch evolved.
We do need to clear unconditionally on other things like machine
checks, I'll give that another sweep.
Cheers,
Ben.
- Re: [Qemu-devel] [Qemu-ppc] [PATCH 13/77] ppc: tlbie, tlbia and tlbisync are HV only, (continued)
[Qemu-devel] [PATCH 19/77] ppc: Fix POWER7 and POWER8 exception definitions, Benjamin Herrenschmidt, 2015/11/10
[Qemu-devel] [PATCH 17/77] ppc: Add PPC_64H instruction flag to POWER7 and POWER8, Benjamin Herrenschmidt, 2015/11/10
[Qemu-devel] [PATCH 20/77] ppc: Fix generation if ISI/DSI vs. HV mode, Benjamin Herrenschmidt, 2015/11/10
[Qemu-devel] [PATCH 18/77] ppc: Rework POWER7 & POWER8 exception model, Benjamin Herrenschmidt, 2015/11/10
[Qemu-devel] [PATCH 21/77] ppc: Rework generation of priv and inval interrupts, Benjamin Herrenschmidt, 2015/11/10
[Qemu-devel] [PATCH 28/77] ppc/xics: Rename existing XICS classe to XICS_SPAPR, Benjamin Herrenschmidt, 2015/11/10
[Qemu-devel] [PATCH 25/77] ppc: Add P7/P8 Power Management instructions, Benjamin Herrenschmidt, 2015/11/10