[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/4] qjson: do not save/restore contexts
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/4] qjson: do not save/restore contexts |
Date: |
Mon, 23 Nov 2015 20:18:52 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/23/15 19:09, Paolo Bonzini wrote:
>
>
> On 23/11/2015 18:59, Laszlo Ersek wrote:
>>>> The only interesting thing is that parse_keyword always eats
>>>> a TOKEN_KEYWORD, even if it is invalid, so it must come last in
>>>> parse_value (otherwise, NULL is returned, parse_literal is invoked
>>>> and it tries to peek beyond end of input). This is caught by
>>>> /errors/unterminated/literal, which actually checks for an unterminated
>>>> keyword. ಠ_ಠ
>> Is it accepted practice to put UTF-8 in commit messages? (Or, actually,
>> anywhere in patches, except maybe the notes section?)
>>
>> I'd recommend o_O.
>
> Perhaps not Kannada, but Unicode 0xA1 to 0x1FF is pretty common in
> commit messages.
That seems to be a subset of the union of the following three:
https://en.wikipedia.org/wiki/Latin-1_Supplement_%28Unicode_block%29
https://en.wikipedia.org/wiki/Latin_Extended-A
https://en.wikipedia.org/wiki/Latin_Extended-B
Thanks for the info,
Laszlo
- [Qemu-devel] [PATCH v2 for-2.5? 0/4] qjson: save a lot of memory, Paolo Bonzini, 2015/11/23
- [Qemu-devel] [PATCH v2 1/4] qjson: replace QString in JSONLexer with GString, Paolo Bonzini, 2015/11/23
- [Qemu-devel] [PATCH v2 2/4] qjson: do not save/restore contexts, Paolo Bonzini, 2015/11/23
- Re: [Qemu-devel] [PATCH v2 2/4] qjson: do not save/restore contexts, Gerd Hoffmann, 2015/11/24
- Re: [Qemu-devel] [PATCH v2 2/4] qjson: do not save/restore contexts, Laszlo Ersek, 2015/11/24
- Re: [Qemu-devel] [PATCH v2 2/4] qjson: do not save/restore contexts, Paolo Bonzini, 2015/11/24
- Re: [Qemu-devel] [PATCH v2 2/4] qjson: do not save/restore contexts, Fam Zheng, 2015/11/24
- Re: [Qemu-devel] [PATCH v2 2/4] qjson: do not save/restore contexts, Paolo Bonzini, 2015/11/24
- Re: [Qemu-devel] [PATCH v2 2/4] qjson: do not save/restore contexts, Markus Armbruster, 2015/11/24
- Re: [Qemu-devel] [PATCH v2 2/4] qjson: do not save/restore contexts, Gerd Hoffmann, 2015/11/24
- Re: [Qemu-devel] [PATCH v2 2/4] qjson: do not save/restore contexts, Laszlo Ersek, 2015/11/24