[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.6 01/14] block: Add "file" output paramete
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH for-2.6 01/14] block: Add "file" output parameter to block status query functions |
Date: |
Tue, 24 Nov 2015 13:42:59 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, 11/23 22:30, Eric Blake wrote:
> On 11/23/2015 10:21 PM, Fam Zheng wrote:
> > The added parameter can be used to return the BDS pointer which the
> > valid offset is refering to. It's value should be ignored unless
>
> s/refering/referring/
>
> > BDRV_BLOCK_OFFSET_VALID in ret is set.
> >
> > Until block drivers fill in the right value, let's clear it explicitly
> > right before calling .bdrv_get_block_status.
> >
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
>
> Reviewed-by: Eric Blake <address@hidden>
>
> Is there ever going to be a need to expose this through QMP, or is this
> just used for the qemu-img map subcommand?
>
I don't think QMP has exposure of information in block address level; for now
it is only used by qemu-img map, which has a "json" output format that can be
used by upper layer tools.
Thanks,
Fam
[Qemu-devel] [PATCH for-2.6 03/14] qcow2: Assign bs->file->bs to file in qcow2_co_get_block_status, Fam Zheng, 2015/11/24
[Qemu-devel] [PATCH for-2.6 04/14] raw: Assign bs to file in raw_co_get_block_status, Fam Zheng, 2015/11/24
[Qemu-devel] [PATCH for-2.6 05/14] iscsi: Assign bs to file in iscsi_co_get_block_status, Fam Zheng, 2015/11/24