[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.5 v2 0/2] qga: flush explicitly when neede
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH for-2.5 v2 0/2] qga: flush explicitly when needed |
Date: |
Tue, 24 Nov 2015 13:47:45 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/24/2015 11:04 AM, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
>
> Without this change, a write() followed by a read() may lose the
> previously written content, as shown in the following test.
>
> v1->v2:
> - replace guchar with unsigned char
> - fix implicitly/explictly
> - comment space fix
Counts as a bug fix, so I'm suggesting that this series goes in 2.5;
although the behavior itself has been broken for a longer time so it is
not critical if it stalls until 2.6.
>
> Marc-André Lureau (2):
> qga: flush explicitly when needed
> tests: add file-write-read test
>
> qga/commands-posix.c | 22 ++++++++++++
> tests/test-qga.c | 95
> ++++++++++++++++++++++++++++++++++++++++++++++++++--
> 2 files changed, 115 insertions(+), 2 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature