[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/1] ide-test: fix timeouts
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/1] ide-test: fix timeouts |
|
Date: |
Wed, 25 Nov 2015 10:22:29 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 24.11.2015 um 20:36 hat John Snow geschrieben:
> Use explicit timeouts instead of trying to approximate it by counting
> the cumulative duration of nsleep calls.
>
> In practice, the timeout if inb() dwarfed the nsleep delays, and as a
> result the real timeout value became a lot larger than 5 seconds.
>
> So: change the semantics from "Not sooner than 5 seconds" to "no more
> than 5 seconds" to ensure we don't hang the tester for very long.
>
> Signed-off-by: John Snow <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>