[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/2] tests: add file-write-read test
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/2] tests: add file-write-read test |
Date: |
Wed, 25 Nov 2015 09:41:35 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/25/2015 09:21 AM, Michael Roth wrote:
>>> + /* seek to 0 */
>>> + cmd = g_strdup_printf("{'execute': 'guest-file-seek',"
>>> + " 'arguments': { 'handle': %" PRId64 ", "
>>> + " 'offset': %d, 'whence': %d } }",
>>> + id, 0, SEEK_SET);
>>
>> We still have a conflict between this series and my proposal to codify 0
>> rather than relying on platform-specific SEEK_SET; Markus had the
>> suggestion of using QGA_SET (or QGA_SEEK_SET). Are we trying to get
>> both your series and my v2 patch into 2.5? Knowing that will help me
>> decide whether my v2 should be rebased on top of your patches.
>
> I was planning on pulling in your patch on top of this for the next
> 2.5 pull, so rebasing on top of this series is probably best.
Okay, will do, and will do quickly so I'm not holding up your pull request.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 0/2] qga: flush explicitly when needed, marcandre . lureau, 2015/11/25
- [Qemu-devel] [PATCH v3 1/2] qga: flush explicitly when needed, marcandre . lureau, 2015/11/25
- [Qemu-devel] [PATCH v3 2/2] tests: add file-write-read test, marcandre . lureau, 2015/11/25
- Re: [Qemu-devel] [PATCH v3 2/2] tests: add file-write-read test, Eric Blake, 2015/11/25
- Re: [Qemu-devel] [PATCH v3 2/2] tests: add file-write-read test, Michael Roth, 2015/11/25
- Re: [Qemu-devel] [PATCH v3 2/2] tests: add file-write-read test,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v3 2/2] tests: add file-write-read test, Michael Roth, 2015/11/25
- Re: [Qemu-devel] [PATCH v3 2/2] tests: add file-write-read test, Eric Blake, 2015/11/25
- Re: [Qemu-devel] [PATCH v3 2/2] tests: add file-write-read test, Michael Roth, 2015/11/25
- Re: [Qemu-devel] [PATCH v3 2/2] tests: add file-write-read test, Eric Blake, 2015/11/25
- Re: [Qemu-devel] [PATCH v3 2/2] tests: add file-write-read test, Michael Roth, 2015/11/25
Re: [Qemu-devel] [PATCH v3 0/2] qga: flush explicitly when needed, Michael Roth, 2015/11/25