[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL for-2.5 3/6] qga: flush explicitly when needed
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PULL for-2.5 3/6] qga: flush explicitly when needed |
Date: |
Wed, 25 Nov 2015 16:45:44 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/25/2015 03:47 PM, Michael Roth wrote:
> From: Marc-André Lureau <address@hidden>
>
> According to the specification:
> http://pubs.opengroup.org/onlinepubs/9699919799/functions/fopen.html
>
> "the application shall ensure that output is not directly followed by
> input without an intervening call to fflush() or to a file positioning
> function (fseek(), fsetpos(), or rewind()), and input is not directly
> followed by output without an intervening call to a file positioning
> function, unless the input operation encounters end-of-file."
>
> Without this change, an fwrite() followed by an fread() may lose the
> previously written content, as shown in the following test.
>
> Fixes:
> https://bugzilla.redhat.com/show_bug.cgi?id=1210246
>
> Reviewed-by: Eric Blake <address@hidden>
> * don't confuse {write,read}() with f{write,read}() in
> commit msg (Laszlo)
> Signed-off-by: Michael Roth <address@hidden>
> ---
Looks like you lost Marc-Andre's S-o-b :(
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PULL for-2.5 0/6] qemu-ga patch queue for 2.5, Michael Roth, 2015/11/25
- [Qemu-devel] [PULL for-2.5 1/6] makefile: fix qemu-ga make install for --disable-tools, Michael Roth, 2015/11/25
- [Qemu-devel] [PULL for-2.5 2/6] qga: gspawn() console helper to Windows guest agent msi build, Michael Roth, 2015/11/25
- [Qemu-devel] [PULL for-2.5 3/6] qga: flush explicitly when needed, Michael Roth, 2015/11/25
- Re: [Qemu-devel] [PULL for-2.5 3/6] qga: flush explicitly when needed,
Eric Blake <=
- [Qemu-devel] [PULL for-2.5 4/6] tests: add file-write-read test, Michael Roth, 2015/11/25
- [Qemu-devel] [PULL for-2.5 5/6] qga: Better mapping of SEEK_* in guest-file-seek, Michael Roth, 2015/11/25
- [Qemu-devel] [PULL for-2.5 6/6] qga: added another non-interactive gspawn() helper file., Michael Roth, 2015/11/25
- Re: [Qemu-devel] [PULL for-2.5 0/6] qemu-ga patch queue for 2.5, Eric Blake, 2015/11/25