[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v13 00/14] qapi member collision (post-introspec
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v13 00/14] qapi member collision (post-introspection cleanups, subset D) |
Date: |
Fri, 27 Nov 2015 10:56:18 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake <address@hidden> writes:
> Pending prerequisites:
> + Markus' "typedefs: Put them back into alphabetical order"
> https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg04417.html
> + Markus' qapi-next branch
> http://repo.or.cz/qemu/armbru.git/shortlog/refs/heads/qapi-next
>
> Also available as a tag at this location:
> git fetch git://repo.or.cz/qemu/ericb.git qapi-cleanupv13d
>
> and will soon be part of my branch with the rest of the v5 series, at:
> http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi
I'm not too fond of PATCH 11, but can't see a better way to do what it
does. However, I don't yet understand why doing it is useful. I
inquired about its use in PATCH 12, perhaps you can enlighten me there.
Other than that, just a few nitpicks. One more respin should take care
of them.
- [Qemu-devel] [PATCH v13 04/14] qapi: Simplify visiting of alternate types, (continued)
- [Qemu-devel] [PATCH v13 04/14] qapi: Simplify visiting of alternate types, Eric Blake, 2015/11/20
- [Qemu-devel] [PATCH v13 12/14] qapi: Enforce (or whitelist) case conventions on qapi members, Eric Blake, 2015/11/20
- [Qemu-devel] [PATCH v13 01/14] qobject: Simplify QObject, Eric Blake, 2015/11/20
- [Qemu-devel] [PATCH v13 02/14] qobject: Rename qtype_code to QType, Eric Blake, 2015/11/20
- [Qemu-devel] [PATCH v13 06/14] qapi: Fix alternates that accept 'number' but not 'int', Eric Blake, 2015/11/20
- [Qemu-devel] [PATCH v13 13/14] qapi: Move duplicate collision checks to schema check(), Eric Blake, 2015/11/20
- Re: [Qemu-devel] [PATCH v13 00/14] qapi member collision (post-introspection cleanups, subset D),
Markus Armbruster <=