[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 for-2.5] vmxnet3: silence warning
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 for-2.5] vmxnet3: silence warning |
Date: |
Mon, 30 Nov 2015 14:44:17 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 30/11/2015 14:20, Michael S. Tsirkin wrote:
> vmxnet3 always produces a warning under qtest.
>
> This is not a user error, don't warn.
>
> Suggested-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/net/vmxnet3.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
> index 5e3a233..0e9e6d9 100644
> --- a/hw/net/vmxnet3.c
> +++ b/hw/net/vmxnet3.c
> @@ -25,6 +25,7 @@
> #include "qemu/bswap.h"
> #include "hw/pci/msix.h"
> #include "hw/pci/msi.h"
> +#include "sysemu/qtest.h"
>
> #include "vmxnet3.h"
> #include "vmxnet_debug.h"
> @@ -2015,7 +2016,9 @@ static bool vmxnet3_peer_has_vnet_hdr(VMXNET3State *s)
> return true;
> }
>
> - VMW_WRPRN("Peer has no virtio extension. Task offloads will be
> emulated.");
> + if (!qtest_enabled()) {
> + VMW_WRPRN("Peer has no virtio extension. Task offloads will be
> emulated.");
> + }
> return false;
> }
>
>
Isn't this v1 again? :)
Paolo