Re: [Qemu-devel] [Qemu-block] [PATCH v2 01/21] qcow2: Add .bdrv_join_options callback

[Alberto Garcia]

On Mon 23 Nov 2015 04:59:40 PM CET, Kevin Wolf <address@hidden> wrote:
> qcow2 accepts a few driver-specific options that overlap semantically
> (e.g. "overlap-check" is an alias of "overlap-check.template", and any
> missing cache size option is derived from the given ones).
>
> When bdrv_reopen() merges the set of updated options with left out
> options that should be kept at their old value, we need to consider this
> and filter out any duplicates (which would generally cause errors
> because new and old value would contradict each other).
>
> This patch adds a .bdrv_join_options callback to BlockDriver and
> implements it for qcow2.
>
> Signed-off-by: Kevin Wolf <address@hidden>

Reviewed-by: Alberto Garcia <address@hidden>

Berto