[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 05/12] dump-guest-memory: introduce dump_proc
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v3 05/12] dump-guest-memory: introduce dump_process() helper function. |
Date: |
Tue, 1 Dec 2015 11:12:00 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Nov 30, 2015 at 01:55:01PM +0100, Paolo Bonzini wrote:
>
>
> On 30/11/2015 12:32, Peter Xu wrote:
> > if (*errp) {
> > s->status = DUMP_STATUS_FAILED;
>
> Why not move this "if" to dump_process as well?
Yes. I did that in another patch. I will move it to this patch,
which should be better.
Thanks.
Peter
>
> Paolo
- Re: [Qemu-devel] [PATCH v3 02/12] dump-guest-memory: add "detach" flag for QMP/HMP interfaces., (continued)
- [Qemu-devel] [PATCH v3 03/12] dump-guest-memory: using static DumpState, add DumpStatus, Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 04/12] dump-guest-memory: add dump_in_progress() helper function, Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 05/12] dump-guest-memory: introduce dump_process() helper function., Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 06/12] dump-guest-memory: disable dump when in INMIGRATE state, Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 07/12] dump-guest-memory: add "detach" support, Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 08/12] dump-guest-memory: add qmp event DUMP_COMPLETED, Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 09/12] DumpState: adding total_size and written_size fields, Peter Xu, 2015/11/30
- [Qemu-devel] [PATCH v3 10/12] Dump: add qmp command "query-dump", Peter Xu, 2015/11/30