[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] coverity: Model g_memdup()
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] coverity: Model g_memdup() |
Date: |
Tue, 1 Dec 2015 10:32:53 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 30/11/2015 17:32, Markus Armbruster wrote:
> We model all the non-deprecated memory allocation functions from
> https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html
> except for g_memdup(), g_clear_pointer(), g_steal_pointer(). We don't
> use the latter two. Model the former.
>
> Coverity now reports an OVERRUN
> vl.c:2317: alloc_strlen: Allocating insufficient memory for the terminating
> null of the string.
> Correct, but we omit the terminating null intentionally there.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> scripts/coverity-model.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/scripts/coverity-model.c b/scripts/coverity-model.c
> index 617f67d..e1d5f45 100644
> --- a/scripts/coverity-model.c
> +++ b/scripts/coverity-model.c
> @@ -236,6 +236,23 @@ void *g_try_realloc(void *ptr, size_t size)
> return g_try_realloc_n(ptr, 1, size);
> }
>
> +/* Other memory allocation functions */
> +
> +void *g_memdup(const void *ptr, unsigned size)
> +{
> + unsigned char *dup;
> + unsigned i;
> +
> + if (!ptr) {
> + return NULL;
> + }
> +
> + dup = g_malloc(size);
> + for (i = 0; i < size; i++)
> + dup[i] = ((unsigned char *)ptr)[i];
> + return dup;
> +}
> +
> /*
> * GLib string allocation functions
> */
>
Reviewed-by: Paolo Bonzini <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH] coverity: Model g_memdup(),
Paolo Bonzini <=