|
From: | Denis V. Lunev |
Subject: | Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command |
Date: | Tue, 1 Dec 2015 17:28:59 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/18/2015 02:36 PM, Juan Quintela wrote:
Markus Armbruster <address@hidden> wrote:"Denis V. Lunev" <address@hidden> writes:Signed-off-by: Denis V. Lunev <address@hidden> CC: Juan Quintela <address@hidden> CC: Amit Shah <address@hidden> CC: Markus Armbruster <address@hidden> CC: Eric Blake <address@hidden> --- migration/savevm.c | 5 +++++ qapi-schema.json | 13 +++++++++++++ qmp-commands.hx | 25 +++++++++++++++++++++++++ 3 files changed, 43 insertions(+) diff --git a/migration/savevm.c b/migration/savevm.c index f83ffd0..565b10a 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -2010,6 +2010,11 @@ void hmp_savevm(Monitor *mon, const QDict *qdict) } }+void qmp_savevm(bool has_name, const char *name, Error **errp)+{ + do_savevm(has_name ? name : NULL, errp); +} +Please name do_savevm() qmp_savevm() and drop this wrapper. We're working on omitting has_FOO for pointer-valued FOO.Agreed.
is there a tree with this stuff in or something I could be based on? This series is simple enough to be written fast and be merged early when the hard freeze will be done. Above stuff could have a way harder way due to the amount of changes to be performed. Den
[Prev in Thread] | Current Thread | [Next in Thread] |