qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/13] pc: Add PCMachineState::pci_host field


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH 01/13] pc: Add PCMachineState::pci_host field
Date: Thu, 3 Dec 2015 14:35:13 -0200
User-agent: Mutt/1.5.23 (2014-03-12)

On Thu, Dec 03, 2015 at 05:35:03PM +0200, Marcel Apfelbaum wrote:
> On 12/03/2015 12:22 AM, Eduardo Habkost wrote:
> >This will allow us to avoid direct references to piix and q35 in
> >acpi-build.c.
> >
> >Signed-off-by: Eduardo Habkost <address@hidden>
[...]
> >diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> >index 6ff4721..8b184c1 100644
> >--- a/include/hw/i386/pc.h
> >+++ b/include/hw/i386/pc.h
> >@@ -38,6 +38,7 @@ struct PCMachineState {
> >      OnOffAuto vmport;
> >      OnOffAuto smm;
> >      ram_addr_t below_4g_mem_size, above_4g_mem_size;
> >+    PCIHostState *pci_host;
> 
> Having both pci_host and bus as class fields is not needed.
> If you have the host, maybe you can get rid of the bus.

Yes, I will send that as folllow-up.

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]