[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/13] pc: Add PCMachineState::pci_host field
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 01/13] pc: Add PCMachineState::pci_host field |
Date: |
Thu, 3 Dec 2015 14:35:13 -0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Dec 03, 2015 at 05:35:03PM +0200, Marcel Apfelbaum wrote:
> On 12/03/2015 12:22 AM, Eduardo Habkost wrote:
> >This will allow us to avoid direct references to piix and q35 in
> >acpi-build.c.
> >
> >Signed-off-by: Eduardo Habkost <address@hidden>
[...]
> >diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> >index 6ff4721..8b184c1 100644
> >--- a/include/hw/i386/pc.h
> >+++ b/include/hw/i386/pc.h
> >@@ -38,6 +38,7 @@ struct PCMachineState {
> > OnOffAuto vmport;
> > OnOffAuto smm;
> > ram_addr_t below_4g_mem_size, above_4g_mem_size;
> >+ PCIHostState *pci_host;
>
> Having both pci_host and bus as class fields is not needed.
> If you have the host, maybe you can get rid of the bus.
Yes, I will send that as folllow-up.
--
Eduardo
- [Qemu-devel] [PATCH 00/13] acpi: Make piix-specific and q35-specific code generic, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 03/13] acpi: Eliminate acpi_get_i386_pci_host() function, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 02/13] acpi: Remove unnecessary check for NULL pci_host, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 01/13] pc: Add PCMachineState::pci_host field, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 04/13] acpi: Move DSDT info to PCMachineClass, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 05/13] acpi: Simplify s3/s4 property querying, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 06/13] acpi: Use &error_abort when getting PCI hotplug properties, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 07/13] acpi: Use QOM property to get CPU hotplug I/O base, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 08/13] acpi: Always try to init PCI hotplug I/O base, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 10/13] acpi: Change acpi_pci_hotplug_enabled() argument to PCMachineState, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 09/13] acpi: Use PCMachineState::acpi_dev to get ACPI dev, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 12/13] intel_iommu.h: Missing sysbus.h include, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 11/13] acpi: Don't use find_i440fx() when setting bsel properties, Eduardo Habkost, 2015/12/03
- [Qemu-devel] [PATCH 13/13] acpi: Don't include q35 and piix headers, Eduardo Habkost, 2015/12/03