qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.5 3/3] spapr_drc: Make device "spapr-dr-co


From: David Gibson
Subject: Re: [Qemu-devel] [PATCH for-2.5 3/3] spapr_drc: Make device "spapr-dr-connector" unavailable with -device
Date: Fri, 4 Dec 2015 10:55:03 +1100
User-agent: Mutt/1.5.24 (2015-08-30)

On Thu, Dec 03, 2015 at 05:37:40PM +0100, Markus Armbruster wrote:
> It should only be created via spapr_dr_connector_new().  Attempting to
> create it with -device crashes.
> 
> Signed-off-by: Markus Armbruster <address@hidden>

Acked-by: David Gibson <address@hidden>

> ---
>  hw/ppc/spapr_drc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
> index dad157f..8be62c3 100644
> --- a/hw/ppc/spapr_drc.c
> +++ b/hw/ppc/spapr_drc.c
> @@ -599,6 +599,10 @@ static void spapr_dr_connector_class_init(ObjectClass 
> *k, void *data)
>      drck->attach = attach;
>      drck->detach = detach;
>      drck->release_pending = release_pending;
> +    /*
> +     * Reason: it crashes FIXME find and document the real reason
> +     */
> +    dk->cannot_instantiate_with_device_add_yet = true;
>  }
>  
>  static const TypeInfo spapr_dr_connector_info = {

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]