[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/9] bt: avoid unintended sign extension
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 2/9] bt: avoid unintended sign extension |
Date: |
Fri, 4 Dec 2015 09:57:33 +0300 |
From: Paolo Bonzini <address@hidden>
In the case of a 4-byte length, shifting a value by 24 may cause
an unintended sign extension when converting from int to size_t.
Use a uint32_t variable instead.
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/bt/sdp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/bt/sdp.c b/hw/bt/sdp.c
index b9bcdcc..04eaeca 100644
--- a/hw/bt/sdp.c
+++ b/hw/bt/sdp.c
@@ -42,7 +42,7 @@ struct bt_l2cap_sdp_state_s {
static ssize_t sdp_datalen(const uint8_t **element, ssize_t *left)
{
- size_t len = *(*element) ++ & SDP_DSIZE_MASK;
+ uint32_t len = *(*element) ++ & SDP_DSIZE_MASK;
if (!*left)
return -1;
--
2.1.4
- [Qemu-devel] [PULL for-2.5 0/9] Trivial patches for 2015-12-04, Michael Tokarev, 2015/12/04
- [Qemu-devel] [PULL 7/9] scsi: remove scsi_req_free prototype, Michael Tokarev, 2015/12/04
- [Qemu-devel] [PULL 9/9] bt: check struct sizes, Michael Tokarev, 2015/12/04
- [Qemu-devel] [PULL 5/9] configure: use appropriate code fragment for -fstack-protector checks, Michael Tokarev, 2015/12/04
- [Qemu-devel] [PULL 1/9] util/id: fully allocate names table, Michael Tokarev, 2015/12/04
- [Qemu-devel] [PULL 6/9] gt64xxx: fix decoding of ISD register, Michael Tokarev, 2015/12/04
- [Qemu-devel] [PULL 3/9] configure: Diagnose broken linkers directly, Michael Tokarev, 2015/12/04
- [Qemu-devel] [PULL 2/9] bt: avoid unintended sign extension,
Michael Tokarev <=
- [Qemu-devel] [PULL 4/9] crypto: avoid two coverity false positive error reports, Michael Tokarev, 2015/12/04
- [Qemu-devel] [PULL 8/9] typedefs: Put them back into alphabetical order, Michael Tokarev, 2015/12/04
- Re: [Qemu-devel] [PULL for-2.5 0/9] Trivial patches for 2015-12-04, Peter Maydell, 2015/12/04