qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv2 01/10] pseries: Remove redundant setting of mc


From: Alexey Kardashevskiy
Subject: Re: [Qemu-devel] [PATCHv2 01/10] pseries: Remove redundant setting of mc->name for pseries-2.5 machine
Date: Wed, 9 Dec 2015 14:31:40 +1100
User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0

On 12/07/2015 02:34 PM, David Gibson wrote:
98cec76 "machine: Set MachineClass::name automatically" removed the setting
of mc->name for the pseries machine types, since it can be derived
automatically from the type names constructed with MACHINE_TYPE_NAME().

Unfortunately fb0fc8f "spapr: Create pseries-2.5 machine" went in later and
brought one of them back.

This removes it again.

Signed-off-by: David Gibson <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
---
  hw/ppc/spapr.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 29a16b7..a69856f 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -2440,7 +2440,6 @@ static void spapr_machine_2_5_class_init(ObjectClass *oc, 
void *data)
      MachineClass *mc = MACHINE_CLASS(oc);
      sPAPRMachineClass *smc = SPAPR_MACHINE_CLASS(oc);

-    mc->name = "pseries-2.5";
      mc->desc = "pSeries Logical Partition (PAPR compliant) v2.5";
      mc->alias = "pseries";
      mc->is_default = 1;

Reviewed-by: Alexey Kardashevskiy <address@hidden>        

--
Alexey



reply via email to

[Prev in Thread] Current Thread [Next in Thread]