Re: [Qemu-devel] [PATCH for-2.5] sparc: allow CASA with ASI 0xa from user space

[Mark Cave-Ayland]

On 08/12/15 21:28, Peter Maydell wrote:

> On 8 December 2015 at 19:59, Richard Henderson <address@hidden> wrote:
>> On 12/04/2015 07:01 AM, Alex Zuepke wrote:
>>> LEON3 allows the CASA instruction to be used from user space
>>> if the ASI is set to 0xa (user data).
>>>
>>> Signed-off-by: Alex Zuepke <address@hidden>
>>> ---
>>>  target-sparc/translate.c | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/target-sparc/translate.c b/target-sparc/translate.c
>>> index 41a3319..63440dd 100644
>>> --- a/target-sparc/translate.c
>>> +++ b/target-sparc/translate.c
>>> @@ -5097,7 +5097,8 @@ static void disas_sparc_insn(DisasContext * dc, 
>>> unsigned int insn)
>>>                      if (IS_IMM) {
>>>                          goto illegal_insn;
>>>                      }
>>> -                    if (!supervisor(dc)) {
>>> +                    /* LEON3 allows CASA from user space with ASI 0xa */
>>> +                    if ((GET_FIELD(insn, 19, 26) != 0xa) && 
>>> !supervisor(dc)) {
>>>                          goto priv_insn;
>>>                      }
>>>  #endif
>>>
>>
>> Reviewed-by: Richard Henderson <address@hidden>
>>
>> This should probably be merged for 2.5.
> 
> Very late, but a very small patch which only affects TCG SPARC,
> so I'm OK with applying it to master. (Mark, did you want to ack/review?)

My understanding from this thread is that it only affects LEON3 - while
I don't have any such images to test with, given that it's restricted to
LEON3 then I'd be fine if you were to apply this to master with an R-B
from Richard and Fabien (I'll do another OpenBIOS test suite run over
the weekend just to be sure).


ATB,

Mark.