[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 24/74] acpi: extend aml_interrupt() to support m
From: |
Shannon Zhao |
Subject: |
Re: [Qemu-devel] [PATCH 24/74] acpi: extend aml_interrupt() to support multiple irqs |
Date: |
Thu, 10 Dec 2015 09:50:29 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 2015/12/10 7:41, Igor Mammedov wrote:
> static void acpi_dsdt_add_virtio(Aml *scope,
> const MemMapEntry *virtio_mmio_memmap,
> - int mmio_irq, int num)
> + uint32_t mmio_irq, int num)
> {
> hwaddr base = virtio_mmio_memmap->base;
> hwaddr size = virtio_mmio_memmap->size;
> - int irq = mmio_irq;
> + uint32_t irq = mmio_irq;
> int i;
>
> for (i = 0; i < num; i++) {
> @@ -152,15 +152,15 @@ static void acpi_dsdt_add_virtio(Aml *scope,
> aml_append(crs, aml_memory32_fixed(base, size, AML_READ_WRITE));
> aml_append(crs,
> aml_interrupt(AML_CONSUMER, AML_LEVEL, AML_ACTIVE_HIGH,
> - AML_EXCLUSIVE, irq + i));
> + AML_EXCLUSIVE, &irq, 1));
This looks not right. You could move uint32_t irq = mmio_irq; into the
for loop and make it as uint32_t irq = mmio_irq + i;
Thanks,
--
Shannon
- [Qemu-devel] [PATCH 53/74] pc: acpi: move PIIX4 isa-bridge and pm devices into SSDT, (continued)
- [Qemu-devel] [PATCH 53/74] pc: acpi: move PIIX4 isa-bridge and pm devices into SSDT, Igor Mammedov, 2015/12/09
- [Qemu-devel] [PATCH 17/74] acpi: add aml_lgreater(), Igor Mammedov, 2015/12/09
- [Qemu-devel] [PATCH 19/74] acpi: add aml_to_hexstring(), Igor Mammedov, 2015/12/09
- [Qemu-devel] [PATCH 18/74] acpi: extend aml_field() to support LockRule, Igor Mammedov, 2015/12/09
- [Qemu-devel] [PATCH 21/74] acpi add aml_dma(), Igor Mammedov, 2015/12/09
- [Qemu-devel] [PATCH 27/74] pc: acpi: memhp: move MHPD.MLCK mutex into SSDT, Igor Mammedov, 2015/12/09
- [Qemu-devel] [PATCH 29/74] pc: acpi: memhp: move MHPD.MRST method into SSDT, Igor Mammedov, 2015/12/09
- [Qemu-devel] [PATCH 24/74] acpi: extend aml_interrupt() to support multiple irqs, Igor Mammedov, 2015/12/09
- Re: [Qemu-devel] [PATCH 24/74] acpi: extend aml_interrupt() to support multiple irqs,
Shannon Zhao <=
- Re: [Qemu-devel] [PATCH 24/74] acpi: extend aml_interrupt() to support multiple irqs, Michael S. Tsirkin, 2015/12/22
[Qemu-devel] [PATCH 32/74] pc: acpi: memhp: move MHPD.MEJ0 method into SSDT, Igor Mammedov, 2015/12/09
[Qemu-devel] [PATCH 31/74] pc: acpi: memhp: move MHPD.MOST method into SSDT, Igor Mammedov, 2015/12/09
[Qemu-devel] [PATCH 36/74] pc: acpi: memhp: move \_GPE._E03 into SSDT, Igor Mammedov, 2015/12/09