|
From: | Juan Quintela |
Subject: | Re: [Qemu-devel] [PATCH] Fix xbzrle vs last_sent_block update |
Date: | Fri, 11 Dec 2015 13:24:25 +0100 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
"Dr. David Alan Gilbert (git)" <address@hidden> wrote: > From: "Dr. David Alan Gilbert" <address@hidden> > > My fix (84e7b80a) replaced the last_sent_block update that I'd > removed earlier; however it was too aggressive in the xbzrle case. > > save_xbzrle_page might return '0' to mean that the page didn't > need sending since it was the same as the last sent version; > in this case we can't update 'last_sent_block' since we didn't > actually send it. > > Symptom: 'Illegal RAM offset 1018000' as we try and send a page > to the wrong RAMBlock; potentially that could be a data > corruption if you were really unlucky. > > Fixes: 84e7b80a05c0c44b90533c6cd2f1db5c932ccf77 > > Signed-off-by: Dr. David Alan Gilbert <address@hidden> Reviewed-by: Juan Quintela <address@hidden>
[Prev in Thread] | Current Thread | [Next in Thread] |