[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint |
Date: |
Mon, 14 Dec 2015 19:37:29 +0200 |
On Mon, Dec 14, 2015 at 06:14:37PM +0100, Paolo Bonzini wrote:
>
>
> On 13/12/2015 09:08, Shmulik Ladkani wrote:
> > + pvs_k->parent_dc_realize = dc->realize;
>
> Marcel, Michael,
>
> this creates a really nasty dependency on the contents of pci_qdev_realize.
>
> Can you instead change PCIDeviceClass's pc->is_express to a function
> pointer, and provide a sample implementation pci_is_express_true for the
> devices that set is_express to true?
>
> Thanks,
>
> Paolo
I'm not very familiar with vmw code, and I dislike overusing callbacks.
What exactly would this callback do?
--
MST
- [Qemu-devel] [PATCH v2 0/6] pvscsi: Fine-tune device capabilities, Shmulik Ladkani, 2015/12/13
- [Qemu-devel] [PATCH v2 1/6] vmw_pvscsi: Set device subsystem and revision, Shmulik Ladkani, 2015/12/13
- [Qemu-devel] [PATCH v2 2/6] vmw_pvscsi: Change offset of msi pci capability, Shmulik Ladkani, 2015/12/13
- [Qemu-devel] [PATCH v2 3/6] vmw_pvscsi: Introduce 'x-old-pci-configuration' backword compatability property, Shmulik Ladkani, 2015/12/13
- [Qemu-devel] [PATCH v2 4/6] vmw_pvscsi: coding: Introduce PVSCSIClass, Shmulik Ladkani, 2015/12/13
- [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint, Shmulik Ladkani, 2015/12/13
- Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint, Paolo Bonzini, 2015/12/14
- Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint, Shmulik Ladkani, 2015/12/14
- Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint, Paolo Bonzini, 2015/12/14
- Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint, Shmulik Ladkani, 2015/12/14
- Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint, Michael S. Tsirkin, 2015/12/14
- Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint, Shmulik Ladkani, 2015/12/15
- Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint, Marcel Apfelbaum, 2015/12/14
[Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property, Shmulik Ladkani, 2015/12/13