[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 2/5] block/qapi: always report full_backing_filen
From: |
John Snow |
Subject: |
[Qemu-devel] [PATCH v3 2/5] block/qapi: always report full_backing_filename |
Date: |
Mon, 14 Dec 2015 14:55:13 -0500 |
Always report full_backing_filename, even if it's the same as
backing_filename. In the next patch, full_backing_filename may be
omitted if it cannot be generated instead of allowing e.g. drive_query
to abort if it runs into this scenario.
The presence or absence of the "full" field becomes useful information.
Signed-off-by: John Snow <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
---
block/qapi.c | 7 ++++---
tests/qemu-iotests/043.out | 2 ++
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/block/qapi.c b/block/qapi.c
index 01569da..0e6b333 100644
--- a/block/qapi.c
+++ b/block/qapi.c
@@ -251,9 +251,10 @@ void bdrv_query_image_info(BlockDriverState *bs,
return;
}
- if (strcmp(backing_filename, backing_filename2) != 0) {
- info->full_backing_filename =
- g_strdup(backing_filename2);
+ /* Always report the full_backing_filename if present, even if it's the
+ * same as backing_filename. That they are same is useful info. */
+ if (backing_filename2) {
+ info->full_backing_filename = g_strdup(backing_filename2);
info->has_full_backing_filename = true;
}
diff --git a/tests/qemu-iotests/043.out b/tests/qemu-iotests/043.out
index 33f8cc3..b37d2a3 100644
--- a/tests/qemu-iotests/043.out
+++ b/tests/qemu-iotests/043.out
@@ -44,6 +44,7 @@ cluster_size: 65536
"filename": "TEST_DIR/t.IMGFMT",
"cluster-size": 65536,
"format": "IMGFMT",
+ "full-backing-filename": "TEST_DIR/t.IMGFMT.2.base",
"backing-filename": "TEST_DIR/t.IMGFMT.2.base",
"dirty-flag": false
},
@@ -52,6 +53,7 @@ cluster_size: 65536
"filename": "TEST_DIR/t.IMGFMT.2.base",
"cluster-size": 65536,
"format": "IMGFMT",
+ "full-backing-filename": "TEST_DIR/t.IMGFMT.1.base",
"backing-filename": "TEST_DIR/t.IMGFMT.1.base",
"dirty-flag": false
},
--
2.4.3
- [Qemu-devel] [PATCH v3 0/5] block: allow partial info-block query, John Snow, 2015/12/14
- [Qemu-devel] [PATCH v3 3/5] block/qapi: explicitly warn if !has_full_backing_filename, John Snow, 2015/12/14
- [Qemu-devel] [PATCH v3 1/5] block/qapi: do not redundantly print "actual path", John Snow, 2015/12/14
- [Qemu-devel] [PATCH v3 5/5] block/qapi: allow best-effort query, John Snow, 2015/12/14
- [Qemu-devel] [PATCH v3 4/5] qemu-img: abort when full_backing_filename not present, John Snow, 2015/12/14
- [Qemu-devel] [PATCH v3 2/5] block/qapi: always report full_backing_filename,
John Snow <=
- Re: [Qemu-devel] [PATCH v3 0/5] block: allow partial info-block query, Max Reitz, 2015/12/14