[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' b
From: |
Shmulik Ladkani |
Subject: |
Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property |
Date: |
Tue, 15 Dec 2015 10:13:24 +0200 |
Hi,
On Mon, 14 Dec 2015 20:26:35 +0200 "Michael S. Tsirkin" <address@hidden> wrote:
> > > It's set internally by machine types to avoid breaking
> > > migration. I don't see any reason for users to set it.
> >
> > But they do set it :) albeit only through machine types. I don't think
> > it's different from offloads, just much more specialized.
> >
> > Or do you mean that it could go away if we decide to remove very old
> > machine types? I think we would remove compat properties connected to
> > those machine types as well, even without "x-".
> >
>
> Then we'll break users who set them directly for some reason.
> So x- means "not part of stable ABI".
> No?
BTW, different drivers use different naming approaches.
E.g. d209c744 'hw/audio/intel-hda: Fix MSI capability address'
suggests a "old_msi_addr" property (yes, underscores) for intel-hda.
Michael, you were the reviewer ;-)
Perhaps we can standartize that "c-" prefix denotes compat properties?
Regards,
Shmulik
[Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property, Shmulik Ladkani, 2015/12/13
- Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property, Paolo Bonzini, 2015/12/14
- Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property, Michael S. Tsirkin, 2015/12/14
- Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property, Paolo Bonzini, 2015/12/14
- Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property, Michael S. Tsirkin, 2015/12/14
- Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property, Paolo Bonzini, 2015/12/14
- Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property, Michael S. Tsirkin, 2015/12/14
- Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property,
Shmulik Ladkani <=
Re: [Qemu-devel] [PATCH v2 0/6] pvscsi: Fine-tune device capabilities, Dmitry Fleytman, 2015/12/13