qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH v0 2/9] cpu: Store CPU typename in MachineSt


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [RFC PATCH v0 2/9] cpu: Store CPU typename in MachineState
Date: Tue, 15 Dec 2015 13:31:33 -0200
User-agent: Mutt/1.5.23 (2014-03-12)

On Tue, Dec 15, 2015 at 02:08:09PM +0530, Bharata B Rao wrote:
> On Mon, Dec 14, 2015 at 03:29:49PM -0200, Eduardo Habkost wrote:
[...]
> > * Maybe make it a CPUClass* field instead of a string?
> 
> In the current use case, this base cpu type string is being passed
> to cpu_generic_init(const char *typename, const char *cpu_model)
> to create boot time CPUs with given typename and cpu_mode. So for now
> the string makes sense for use case.
> 
> Making it CPUClass* would necessiate more changes to cpu_generic_init().

I would consider changing cpu_generic_init() to
cpu_generic_init(CPUClass *base_class, const char *cpu_model)
too. But I admit I didn't look at cpu_generic_init() code yet,
and this can be done later if appropriate.

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]