[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 00/23] Error reporting cleanups and fixes
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v2 00/23] Error reporting cleanups and fixes |
Date: |
Thu, 17 Dec 2015 17:49:41 +0100 |
Two topics:
1. New in v2: Avoid error_get_pretty() when all you want is extend an
error message. Doing that with error_get_pretty() loses the error
hint. Provide that don't lose it, and are more convenient to use.
2. Newlines in error messages. Jason Herne's "[PATCH v2] checkpatch:
Detect newlines in error_report and other error functions" will catch
at least some instances of this kind of mistake in the future.
Based on my "[PATCH v3 00/13] Clean up some hw_error() misuse".
I intend to take these patches through my tree.
v2:
* 19 new patches...
* PATCH 1 became PATCH 16
* PATCH 2 became PATCH 21, with commit message typo fixed [László]
* PATCH 3 split into PATCH 17-20, partly rewritten
* PATCH 4 became PATCH 22
Markus Armbruster (23):
qemu-nbd: Replace BSDism <err.h> by error_report()
error: Use error_report_err() where appropriate (again)
error: Use error_report_err() instead of monitor_printf()
error: Use error_report_err() instead of ad hoc prints
error: Improve documentation around error_append_hint()
block: Clean up "Could not create temporary overlay" error message
qemu-nbd: Clean up "Failed to load snapshot" error message
test-throttle: Simplify qemu_init_main_loop() error handling
error: New error_prepend(), error_reportf_err()
error: Don't decorate original error message when adding to it
error: Use error_reportf_err() where it makes obvious sense
error: Use error_prepend() where it makes obvious sense
spapr: Use error_reportf_err()
migration: Use error_reportf_err() instead of monitor_printf()
qemu-io qemu-nbd: Use error_report() etc. instead of fprintf()
error: Strip trailing '\n' from error string arguments (again)
vmdk: Clean up control flow in vmdk_parse_extents() a bit
vmdk: Clean up "Invalid extent lines" error message
pci-assign: Clean up "Failed to assign" error messages
vhdx: Fix "log that needs to be replayed" error message
error: Clean up errors with embedded newlines (again)
hw/s390x: Rename local variables Error *l_err to just err
s390/sclp: Simplify control flow in sclp_realize()
arch_init.c | 4 +-
block.c | 20 +++----
block/qcow2.c | 5 +-
block/qed.c | 5 +-
block/sheepdog.c | 8 +--
block/vhdx-log.c | 13 ++--
block/vmdk.c | 49 +++++++++-------
blockdev.c | 11 ++--
contrib/ivshmem-server/main.c | 4 +-
hmp.c | 29 +++------
hw/arm/cubieboard.c | 9 ++-
hw/arm/digic_boards.c | 3 +-
hw/arm/imx25_pdk.c | 2 +-
hw/arm/kzm.c | 2 +-
hw/arm/netduino2.c | 2 +-
hw/arm/xlnx-ep108.c | 2 +-
hw/arm/xlnx-zynqmp.c | 2 +-
hw/block/dataplane/virtio-blk.c | 8 +--
hw/core/qdev-properties.c | 6 +-
hw/core/qdev.c | 5 +-
hw/i386/kvm/pci-assign.c | 16 ++---
hw/i386/pc.c | 9 ++-
hw/ppc/e500.c | 4 +-
hw/ppc/spapr.c | 10 ++--
hw/ppc/spapr_drc.c | 6 +-
hw/s390x/ipl.c | 12 ++--
hw/s390x/s390-skeys-kvm.c | 2 +-
hw/s390x/s390-skeys.c | 19 +++---
hw/s390x/sclp.c | 21 +++----
hw/scsi/vhost-scsi.c | 6 +-
hw/tpm/tpm_tis.c | 2 +-
hw/usb/bus.c | 11 ++--
include/qapi/error.h | 50 ++++++++++++++--
kvm-all.c | 6 +-
migration/ram.c | 2 +-
migration/savevm.c | 21 +++----
monitor.c | 6 +-
net/vhost-user.c | 6 +-
qdev-monitor.c | 3 +-
qemu-img.c | 33 ++++-------
qemu-io.c | 8 +--
qemu-nbd.c | 127 ++++++++++++++++++++++++----------------
qga/commands-posix.c | 2 +-
replay/replay.c | 3 +-
target-arm/cpu.c | 2 +-
target-arm/machine.c | 4 +-
tests/qemu-iotests/059.out | 12 ++--
tests/qemu-iotests/060.out | 2 +-
tests/qemu-iotests/069.out | 2 +-
tests/qemu-iotests/070.out | 5 +-
tests/qemu-iotests/075.out | 14 ++---
tests/qemu-iotests/076.out | 6 +-
tests/qemu-iotests/078.out | 12 ++--
tests/qemu-iotests/080.out | 36 ++++++------
tests/qemu-iotests/083.out | 34 +++++------
tests/qemu-iotests/088.out | 12 ++--
tests/qemu-iotests/092.out | 24 ++++----
tests/qemu-iotests/103.out | 8 +--
tests/qemu-iotests/114.out | 2 +-
tests/qemu-iotests/116.out | 14 ++---
tests/qemu-iotests/131.out | 2 +-
tests/test-aio.c | 4 +-
tests/test-thread-pool.c | 4 +-
tests/test-throttle.c | 15 +----
ui/vnc.c | 4 +-
util/error.c | 35 ++++++++++-
vl.c | 8 +--
67 files changed, 431 insertions(+), 404 deletions(-)
--
2.4.3
- [Qemu-devel] [PATCH v2 00/23] Error reporting cleanups and fixes,
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 03/23] error: Use error_report_err() instead of monitor_printf(), Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v2 02/23] error: Use error_report_err() where appropriate (again), Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v2 16/23] error: Strip trailing '\n' from error string arguments (again), Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v2 06/23] block: Clean up "Could not create temporary overlay" error message, Markus Armbruster, 2015/12/17
- [Qemu-devel] [PATCH v2 05/23] error: Improve documentation around error_append_hint(), Markus Armbruster, 2015/12/17