[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 7/9] target-arm: dump-guest-memory: add prfpr
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3 7/9] target-arm: dump-guest-memory: add prfpreg notes for aarch64 |
Date: |
Fri, 18 Dec 2015 12:06:36 +0000 |
On 15 December 2015 at 22:51, Andrew Jones <address@hidden> wrote:
> Signed-off-by: Andrew Jones <address@hidden>
> ---
> target-arm/arch_dump.c | 79
> +++++++++++++++++++++++++++++++++++++++++++++-----
> 1 file changed, 71 insertions(+), 8 deletions(-)
> +static int
We don't usually do the 'linebreak before function name' style.
> +aarch64_write_elf64_prfpreg(WriteCoreDumpFunction f, CPUARMState *env,
> + int cpuid, DumpState *s)
> +{
> + struct aarch64_note note;
> + int ret, i;
> +
> + aarch64_note_init(¬e, s, "CORE", 5, NT_PRFPREG, sizeof(note.vfp));
> +
> + for (i = 0; i < 64; ++i) {
> + note.vfp.vregs[i] = cpu_to_dump64(s, float64_val(env->vfp.regs[i]));
> + }
> +
> + if (s->dump_info.d_endian == ELFDATA2MSB) {
> + /* For AArch4 we must always swap the vfp.regs's 2n and 2n+1
"AArch64".
> + * entries when generating BE notes, because even big endian
> + * hosts use 2n+1 for the high half.
> + */
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH v3 0/9] target-arm: enable qmp-dump-guest-memory, Andrew Jones, 2015/12/15
- [Qemu-devel] [PATCH v3 1/9] qapi-schema: dump-guest-memory: Improve text, Andrew Jones, 2015/12/15
- [Qemu-devel] [PATCH v3 2/9] dump: qemunotes aren't commonly needed, Andrew Jones, 2015/12/15
- [Qemu-devel] [PATCH v3 3/9] dump: allow target to set the page size, Andrew Jones, 2015/12/15
- [Qemu-devel] [PATCH v3 4/9] dump: allow target to set the physical base, Andrew Jones, 2015/12/15
- [Qemu-devel] [PATCH v3 5/9] target-arm: introduce aarch64_compat_sp, Andrew Jones, 2015/12/15
- [Qemu-devel] [PATCH v3 6/9] target-arm: support QMP dump-guest-memory, Andrew Jones, 2015/12/15
- [Qemu-devel] [PATCH v3 7/9] target-arm: dump-guest-memory: add prfpreg notes for aarch64, Andrew Jones, 2015/12/15
- Re: [Qemu-devel] [PATCH v3 7/9] target-arm: dump-guest-memory: add prfpreg notes for aarch64,
Peter Maydell <=
- [Qemu-devel] [PATCH v3 8/9] elf: add arm note types, Andrew Jones, 2015/12/15
- [Qemu-devel] [PATCH v3 9/9] target-arm: dump-guest-memory: add vfp notes for arm, Andrew Jones, 2015/12/15