qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] numa: Clean up query-memdev error handling


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH v2] numa: Clean up query-memdev error handling
Date: Fri, 18 Dec 2015 14:00:23 -0200
User-agent: Mutt/1.5.23 (2014-03-12)

On Mon, Nov 23, 2015 at 09:35:31AM +0100, Markus Armbruster wrote:
> qmp_query_memdev() has two error paths:
> 
> * When object_get_objects_root() returns null.  It never does, so
>   simply drop the useless error handling.
> 
> * When query_memdev() fails.  It leaks err then.  But any failure
>   there is actually a programming error.  Switch it to &error_abort,
>   and drop the useless error handling.
> 
> Messed up in commit 76b5d85 "qmp: add query-memdev".
> 
> Signed-off-by: Markus Armbruster <address@hidden>

Reviewed-by: Eduardo Habkost <address@hidden>

Applied to the numa tree. Thanks!

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]