[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/5] linux-user: manage SOCK_PACKET socket ty
From: |
Riku Voipio |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/5] linux-user: manage SOCK_PACKET socket type |
Date: |
Mon, 21 Dec 2015 15:14:49 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Dec 18, 2015 at 04:13:20PM +0100, Laurent Vivier wrote:
> Le 29/10/2015 00:12, Peter Maydell a écrit :
> > On 28 October 2015 at 20:40, Laurent Vivier <address@hidden> wrote:
> >> This is obsolete, but if we want to use dhcp with some distros (like debian
> >> ppc 8.2 jessie), we need it.
> >>
> >> bind() uses an interface name instead an interface index, and socket()
> >> needs network order value to encode the protocol.
> >>
> >> v3: update cover letter message,
> >> insert Reviewed-by: in PATCH 1 and PATCH 2
> >> insert fd_trans_target_to_host_addr into target_to_host_sockaddr and
> >> pass fd, check fd is >= 0, rename packet_target_to_host_addr to
> >> packet_target_to_host_sockaddr
> >>
> >> v2: Split the patch in 4 parts to manage protocol endianness (socket()) and
> >> interface name (bind()) in different patches.
> >> Use TargetFdTrans array to manage the SOCK_PACKET type special case in
> >> bind().
> >> The two others patches are here to introduce a new function in
> >> TargetFdTrans
> >> to translate sockaddr data structure (rename previous functions to be
> >> clear).
> >>
> >> Laurent Fiver (5):
> >
> > This name doesn't match the names on the actual patch mails,
> > but those are right so I guess it doesn't matter.
> >
> >> linux-user: SOCK_PACKET uses network endian to encode protocol in
> >> socket()
> >> linux-user: rename TargetFdFunc to TargetFdDataFunc, and structure
> >> fields accordingly
> >> linux-user: add a function hook to translate sockaddr
> >> linux-user: manage bind with a socket of SOCK_PACKET type.
> >> linux-user: check fd is >= 0 in
> >> fd_trans_host_to_target_data/fd_trans_host_to_target_addr
> >
> > Series
> > Reviewed-by: Peter Maydell <address@hidden>
> Can we have this series applied ?
I'll create next pull req next week, right now I'm a bit busy. If someone
else wants to merge the series before me, you have my Acked-by.
Riku