[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] crypto: add ability to query the cipher key
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/6] crypto: add ability to query the cipher key, block & IV lens |
Date: |
Mon, 21 Dec 2015 09:18:42 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 12/21/2015 09:06 AM, Daniel P. Berrange wrote:
> Adds new methods to allow querying the length of the cipher
> key, block size and initialization vectors.
In the subject line, I read 'lens' as a synonym for 'viewports', not
'lengths'. But I don't know if avoiding the abbreviation is worth it,
because the subject line is already bordering on long. Maybe avoiding
it altogether is easier?
crypto: Add additional query accessors
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> crypto/cipher.c | 48
> ++++++++++++++++++++++++++++++++++++++++++++++
> include/crypto/cipher.h | 37 +++++++++++++++++++++++++++++++++++
> tests/test-crypto-cipher.c | 10 ++++++++++
> 3 files changed, 95 insertions(+)
>
But no problems with the actual patch, so:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/6] Misc enhancements to crypto APIs, Daniel P. Berrange, 2015/12/21
- [Qemu-devel] [PATCH 1/6] crypto: add ability to query the cipher key, block & IV lens, Daniel P. Berrange, 2015/12/21
- Re: [Qemu-devel] [PATCH 1/6] crypto: add ability to query the cipher key, block & IV lens,
Eric Blake <=
- [Qemu-devel] [PATCH 2/6] crypto: add ability to query hash digest len, Daniel P. Berrange, 2015/12/21
- [Qemu-devel] [PATCH 4/6] crypto: move QCryptoCipherAlgorithm/Mode enum definitions into QAPI, Daniel P. Berrange, 2015/12/21
- [Qemu-devel] [PATCH 5/6] crypto: ensure qapi/crypto.json is listed in qapi-modules, Daniel P. Berrange, 2015/12/21
- [Qemu-devel] [PATCH 6/6] crypto: fix transposed arguments in cipher error message, Daniel P. Berrange, 2015/12/21