Re: [Qemu-devel] [PATCH 0/3] correct some register return values for vxmnet3

[Dmitry Fleytman]

Hello Miao,

While patches look good technically, I cannot find any code snippets that prove 
correctness of these changes.
How do you know this is the correct behaviour? Could you please extend commit 
messages with corresponding references?

Thanks,
Dmitry

> On 21 Dec 2015, at 13:06 PM, Miao Yan <address@hidden> wrote:
> 
> Qemu vmxnet3 emulation doesn't recognize VMXNET3_CMD_GET_DID_LO,
> VMXNET3_CMD_GET_DID_HI and VMXNET3_CMD_GET_DEV_EXTRA_INFO command and 
> returns -1 on all of them.
> 
> This patchset makes them return correct values.
> 
> Miao Yan (3):
>  net/vmxnet3: return 1 on device activation failure
>  net/vmxnet3: return correct value for VMXNET3_CMD_GET_DID command
>  net/vmxnet3: return correct value for VMXNET3_CMD_GET_DEV_EXTRA_INFO
> 
> hw/net/vmxnet3.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
> 
> -- 
> 1.9.1
>