Re: [Qemu-devel] [PATCH v8 21/35] qapi: Document visitor interfaces, add assertions

[Marc-André Lureau]

Hi

On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake <address@hidden> wrote:
> The visitor interface for mapping between QObject/QemuOpts/string
> and qapi has formerly been documented only by reading source code,
> making it difficult to propose changes to either scripts/qapi*.py
> or to clients without knowing whether those changes would be safe.
> This adds documentation, including mentioning when parameters can
> be NULL, and where there are still some interface warts that would
> be nice to remove.  In particular, I have plans to remove
> visit_start_union() in a future patch.
>
> Add some asserts to strengthen the claims of the assertions; some
> of these were only made possible by recent cleanup commits.  These
> were made easier with the addition of a new visit_is_output()
> helper (since all 2 output visitors of our 6 overall visitors use
> the same .type_enum() callback).
>
> Signed-off-by: Eric Blake <address@hidden>

Nice doc,
Reviewed-by: Marc-André Lureau <address@hidden>



-- 
Marc-André Lureau