[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 14/35] qapi: Swap visit_* arguments for consi
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v8 14/35] qapi: Swap visit_* arguments for consistent 'name' placement |
|
Date: |
Tue, 5 Jan 2016 15:47:14 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 01/05/2016 08:32 AM, Eric Blake wrote:
>>
>> However, docs/qapi-code-gen.txt should be updated in a follow-up patch.
>
> D'oh - I knew I'd forget something :) You're right, of course.
For that matter, several recent patches have tweaked generated code
without updating the docs, such as 9f08c8ec dropping the automatic
creation of a corresponding UserDefOneList type for the example as
given. I'll bring it back in sync, but now I have to decide how much
(or how little) to actually demonstrate in the docs
(qapi-schema-test.json is a much more thorough testing mechanism for all
the corner cases; the docs only have to demonstrate a couple of common
examples).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature