[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] qemu-char: add logfile facility to all chard
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v3] qemu-char: add logfile facility to all chardev backends |
|
Date: |
Thu, 7 Jan 2016 14:08:08 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 07/01/2016 11:31, Paolo Bonzini wrote:
>
>
> On 23/12/2015 14:27, Daniel P. Berrange wrote:
>> - mon_chr = qemu_chr_alloc();
>> + mon_chr = qemu_chr_alloc(&common, NULL);
>
> Changed NULL to &error_abort, and queued.
Hmm, nope... this is missing documentation of the new options (though it
does mention them in the help). Can you add it for v4?
Paolo
> Paolo
>
>> mon_chr->chr_write = gdb_monitor_write;
>
>