|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH v1 3/6] kvm/x86: Reorg stimer_expiration() to better control timer restart |
Date: | Thu, 7 Jan 2016 17:34:54 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 23/12/2015 12:28, Andrey Smetanin wrote: > - stimer_send_msg(stimer); > - if (!(stimer->config & HV_STIMER_PERIODIC)) > - stimer->config |= ~HV_STIMER_ENABLE; > - else > - stimer_start(stimer); > + stimer->msg_pending = true; > + if (!stimer_send_msg(stimer)) { > + stimer->msg_pending = false; > + if (!(stimer->config & HV_STIMER_PERIODIC)) > + stimer->config |= ~HV_STIMER_ENABLE; Just because this is curious: sure it shouldn't be "&="? Paolo > + }
[Prev in Thread] | Current Thread | [Next in Thread] |