Re: [Qemu-devel] [PATCH 5/6] nvdimm acpi: let qemu handle _DSM method

[Igor Mammedov]

On Fri, 8 Jan 2016 12:01:54 +0800
Xiao Guangrong <address@hidden> wrote:

> On 01/07/2016 10:22 PM, Igor Mammedov wrote:
> > On Tue,  5 Jan 2016 02:52:07 +0800
> > Xiao Guangrong <address@hidden> wrote:
> >  
> >> If dsm memory is successfully patched, we let qemu fully emulate
> >> the dsm method
> >>
> >> This patch saves _DSM input parameters into dsm memory, tell dsm
> >> memory address to QEMU, then fetch the result from the dsm memory  
> > you also need to add NVDR._CRS method that would report
> > resources used by operation regions.  
> 
> I can not understand this point, why we need to report the resource
> of OperationRegion? It is ACPI internally used anyway.
so that OSPM could see that particular range is in use
and be able to notice conflicts if it happens some day.

> 
> >
> > NVDIMM_COMMON_DSM - probably should be serialized, otherwise
> > there is a race risk, when several callers would write to
> > control region.  
> 
> Yes, i did it in patch 6/6, but definitely i should more it to here.
>